Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on boost in chrono.hpp #1076

Merged
merged 3 commits into from Jul 6, 2023
Merged

remove dependency on boost in chrono.hpp #1076

merged 3 commits into from Jul 6, 2023

Conversation

uyha
Copy link

@uyha uyha commented Jul 3, 2023

No description provided.

@uyha uyha marked this pull request as ready for review July 3, 2023 19:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023 •
edited

Codecov Report

Merging #1076 (4bc88d7) into cpp_master (ac062e2) will increase coverage by 0.01%.
The diff coverage is 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@              Coverage Diff               @@
##           cpp_master    #1076      +/-   ##
==============================================
+ Coverage       85.63%   85.64%   +0.01%     
==============================================
  Files              79       79              
  Lines            5040     5058      +18     
==============================================
+ Hits             4316     4332      +16     
- Misses            724      726       +2

@uyha
Copy link
Author

uyha commented Jul 3, 2023

@redboltz I have no idea why this just fails randomly for the chrono test cases, could you have the look?

@redboltz
Copy link
Contributor

redboltz commented Jul 4, 2023

@redboltz I have no idea why this just fails randomly for the chrono test cases, could you have the look?

Hmm, it this also happend the HEAD ac062e2 ?
Or after your modification is applied?

@uyha
Copy link
Author

uyha commented Jul 4, 2023 •
edited

fixed after i pushed 😅 , i forgot to remove the preprocess guard in type.hpp

@uyha uyha requested a review from redboltz July 4, 2023 06:14
redboltz
redboltz requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@redboltz redboltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that some of indents are 3.

include/msgpack/v1/adaptor/cpp11/chrono.hpp Outdated Show resolved Hide resolved
include/msgpack/v1/adaptor/cpp11/chrono.hpp Outdated Show resolved Hide resolved
@uyha uyha requested a review from redboltz July 4, 2023 07:22
@uyha uyha mentioned this pull request Jul 4, 2023
Merged
@redboltz redboltz merged commit 1fb1dad into msgpack:cpp_master Jul 6, 2023
25 checks passed
@redboltz
Copy link
Contributor

redboltz commented Jul 6, 2023

Merged. Thank you!

@uyha uyha mentioned this pull request Jul 6, 2023
Closed
@uyha uyha deleted the chrono-no-boost branch July 6, 2023 05:12
@uyha uyha mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redboltz redboltz redboltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uyha @codecov-commenter @redboltz