Fix to avoid common function name's (has_as::check) ambiguity/conflict with other libraries' macros
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith other libraries/engines's macro definitions (e.g. UE)
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## cpp_master #1085 +/- ##
===========================================
Coverage 85.75% 85.75%
===========================================
Files 80 80
Lines 5091 5091
===========================================
Hits 4366 4366
Misses 725 725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change of a private function name, which can have a big impact for Unreal Engine's users to be able to use msgpack-cxx library as unfortunately some libraries, specially, Unreal Engine use badly named generic/common macro definitions (UE uses since v4.0) and no effort to modify their macro names to something more unique to their engine.
This issue fixes #1050 and was also raised and discussed in #626 in more depth.