Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c++11 code should use nothrow instead of throw() #313

Merged
merged 2 commits into from Jul 12, 2015

Conversation

jonitis
Copy link
Contributor

@jonitis jonitis commented Jul 9, 2015

C++11 should not use deprecated throw(std::bad_alloc) / throw(), but instead use nothrow.

Also there are two

if !defined(MSGPACK_USE_CPP03)

checks in c++11 specific code. Should not this always be true?

@redboltz
Copy link
Contributor

Thank you for sending the PR.

Also there are two
#if !defined(MSGPACK_USE_CPP03)
checks in c++11 specific code. Should not this always be true?

It should be always true.
https://github.com/msgpack/msgpack-c/blob/master/include/msgpack/zone.hpp#L26

I will merge your PR.

redboltz added a commit that referenced this pull request Jul 12, 2015
c++11 code should use nothrow instead of throw()
@redboltz redboltz merged commit b8d357c into msgpack:master Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants