Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated comments to describe #if !define(_MSC_VER) reason. #347

Merged
merged 1 commit into from
Aug 17, 2015
Merged

Updated comments to describe #if !define(_MSC_VER) reason. #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/boost_fusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,12 @@ BOOST_FUSION_ADAPT_STRUCT(
f3 // *3
)

#if !defined(_MSC_VER)

// boost::fusion's adaptor uses std::tuple.
// MSVC2015's std::tuple requires default constructor during 'as' process.
// I don't know why...
// It doesn't support Expression SFINAE yet, then 'as' is fallbacked to 'convert'.
// After MSVC would support Expression SFINAE, remove this guard.
#if !defined(_MSC_VER)

TEST(MSGPACK_BOOST, pack_convert_no_def_con)
{
std::stringstream ss;
Expand Down
7 changes: 5 additions & 2 deletions test/msgpack_cpp11.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,10 +456,13 @@ TEST(MSGPACK_NO_DEF_CON_PAIR, simple_buffer)
EXPECT_EQ(val1, val2);
}

#if !defined(_MSC_VER)


// MSVC2015's std::tuple requires default constructor during 'as' process.
// I don't know why...
// It doesn't support Expression SFINAE yet, then 'as' is fallbacked to 'convert'.
// After MSVC would support Expression SFINAE, remove this guard.
#if !defined(_MSC_VER)

TEST(MSGPACK_NO_DEF_CON_TUPLE, simple_buffer)
{
std::tuple<no_def_con, no_def_con, no_def_con_composite> val1 {1, 2, 3};
Expand Down