Add move semantics to sbuffer in c++11 mode #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for sending the PR.
Thanks, I read EMC++ and 100% agree with you and Scott. |
redboltz
added a commit
that referenced
this pull request
Aug 19, 2015
Add move semantics to sbuffer in c++11 mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbuffer class would benefit from move semantics, so that it can be returned from functions.
P.S.
I've moved deleted copy constructor/assignment operator (= delete) from private section to public. Scott Meyers was suggesting this, so that compiler may provide better error message (not that it is only not accessible, but that it is explicitly deleted).