Print unprintable characters in memory buffer #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smititelu
referenced
this pull request
Jul 19, 2016
In order to print the msgpack object in a memory buffer.
| @@ -344,9 +369,11 @@ int msgpack_object_print_buffer(char *buffer, size_t buffer_size, msgpack_object | |||
| ret = snprintf(aux_buffer, aux_buffer_size, "\""); | |||
| aux_buffer = aux_buffer + ret; | |||
| aux_buffer_size = aux_buffer_size - ret; | |||
| ret = snprintf(aux_buffer, aux_buffer_size, "%.*s", o.via.ext.size, o.via.ext.ptr); | |||
|
|
|||
| ret = msgpack_object_bin_print_buffer(aux_buffer, aux_buffer_size, o.via.bin.ptr, o.via.bin.size); | |||
| aux_buffer = aux_buffer + ret; | |||
There was a problem hiding this comment.
@smititelu , thank you for sending the PR.
It seems that
, o.via.bin.ptr, o.via.bin.size);should be
, o.via.ext.ptr, o.via.ext.size);There was a problem hiding this comment.
Done. Thanks for spotting this.
|
merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this PR, analogous to PR #497. Besides compilation, didn't actually tested it. Tell me if you spot any issues.