Fixed spurious start_map_key/start_array_item calls #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstahlke
force-pushed
the
fix
branch
2 times, most recently
from
b569838
to
1437e37
Compare
|
@dstahlke , thank you for sending the PR. It looks good to me. The PR fixes not only I will merge it. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty arrays/maps can cause spurious calls to visitor functions. The attached test case parses the message
[{},{}]and produces the following output:start_array 2
start_array_item
start_map 0
end_map
end_array_item
start_array_item
start_map_key
start_map 0
end_map
end_array_item
end_array
Notice the start_map_key call occurs outside of the map (and in fact there should be no keys for an empty map).
msgpack_bug.txt