Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment intentional fallthrough in case statements #588

Merged
merged 1 commit into from Apr 26, 2017
Merged

Comment intentional fallthrough in case statements #588

merged 1 commit into from Apr 26, 2017

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Apr 22, 2017

Fixes build with gcc7

Signed-off-by: Khem Raj raj.khem@gmail.com

Fixes build with gcc7

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@redboltz
Copy link
Contributor

@kraj , thank you for sending the PR.
The file you modified is a part of generated code.
In order to add the comment, we need to edit erb code.

I updated your PR.
https://github.com/redboltz/msgpack-c/tree/kraj-devtool
Could you test it on your environment?

@kraj
Copy link
Contributor Author

kraj commented Apr 24, 2017

@redboltz yes I tested that branch and it works here.

@redboltz redboltz merged commit 15d8bb6 into msgpack:master Apr 26, 2017
@redboltz
Copy link
Contributor

merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants