Fix -Werror=class-memaccess with gcc8 #659
Conversation
Casting to void* make gcc happy since its upset about
object types and rightly so
Fixes
'void* memcpy(void*, const void*, size_t)' copying an object of non-trivial type 'struct msgpack::v2::object' from an array of 'const msgpack_object' {aka 'const struct msgpack_object'} [-Werror=class-memaccess]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
@kraj , thank you for sending the PR. merged. |
|
It would be helpful to have a release with this fix, since GCC 8 is starting to be the default GCC version in various distributions. |
|
@jamessan , I will release the next version soon. |
|
Hi, We just stumbled upon the same problem in v1.4.2 after upgrading to Ubuntu 18 and switching to gcc 8. Is it possible to also merge this fix into cpp-1.4 branch? We can also offer a pull request if that eases things for you. BTW: thanks for your great work with the msgpack library! Thanks and kind regards, |
|
@cpraehaus, the current major version of msgpack-c is 3. v1.4.2 is very old. I don't recommend using it. |
msgpack-c commit: 29b9505cb76710802e130d5b8403ec1b40de1c8d Required because of this fix: msgpack/msgpack-c#659 Alpine updated gcc from 6.4.0-r9 in Alpine 3.8 to 8.3.0-r0 so we now encounter this problem.
msgpack-c commit: 29b9505cb76710802e130d5b8403ec1b40de1c8d Required because of this fix: msgpack/msgpack-c#659 Alpine updated gcc from 6.4.0-r9 in Alpine 3.8 to 8.3.0-r0 so we now encounter this problem.
Casting to void* make gcc happy since its upset about
object types and rightly so
Fixes
'void* memcpy(void*, const void*, size_t)' copying an object of non-trivial type 'struct msgpack::v2::object' from an array of 'const msgpack_object' {aka 'const struct msgpack_object'} [-Werror=class-memaccess]
Signed-off-by: Khem Raj raj.khem@gmail.com