Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#542: Add a warning note for the usage of MessageUnpacker.readPayloadAsReference #546

Merged
merged 1 commit into from Feb 15, 2021
Merged

#542: Add a warning note for the usage of MessageUnpacker.readPayloadAsReference #546

merged 1 commit into from Feb 15, 2021

Conversation

xerial
Copy link
Member

@xerial xerial commented Feb 14, 2021

No description provided.

@xerial xerial mentioned this pull request Feb 14, 2021
Open
komamitsu
komamitsu approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user of this method can know the buffer length encoded in the header. Even with a wrong length in header encoded by an attacker, it should be safe as long as the user of this method implements safely.

@xerial xerial merged commit 4976b7f into msgpack:develop Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komamitsu komamitsu komamitsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xerial @komamitsu