-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexpected Uint8Array.prototype.buffer
behavior
#145
Comments
slice might copy the buffer then affect the performance |
As @Jack-Works said, it is intentional. It's not specific to this library. In JavaScript and TypeScript, You MUST NOT use the underlying |
Normally msgpack-javascript should work out of the box as the output of encode is Uint8array but due to this issue we have to initialise it again as the buffer is missing Ref msgpack/msgpack-javascript#145
msgpack-javascript/src/Encoder.ts
Lines 26 to 28 in 0bfe618
References:
DimensionDev/Maskbook#1573
The text was updated successfully, but these errors were encountered: