Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests/041; fixes #108 #109

Closed
wants to merge 1 commit into from
Closed

Conversation

glensc
Copy link

@glensc glensc commented Nov 22, 2016

  • disable bin2hex

removed bin2hex because it's seems to be dependent on php platform (version, os, architecture) and it's seems to be dumping php internal memory not the actual object, tests in this repo should test msgpack not bin2hex() implementation.

  • -0.0 is -0.0 in my platform

this seems also php platform specific?

- disable bin2hex - it's dumping internal memory?
- -0.0 is -0.0 in my platform
@codecov-io
Copy link

Current coverage is 86.29% (diff: 100%)

Merging #109 into master will decrease coverage by 0.57%

@@             master       #109   diff @@
==========================================
  Files             8          8          
  Lines          1249       1233    -16   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1085       1064    -21   
- Misses          164        169     +5   
  Partials          0          0          

Powered by Codecov. Last update 3411376...d8bcd35

glensc added a commit to pld-linux/php-pecl-msgpack that referenced this pull request Nov 22, 2016
@andypost
Copy link
Contributor

#129 just skips this tests

@m6w6
Copy link
Collaborator

m6w6 commented Dec 18, 2019

I merged #129, but this might have been the better fix. NaN has a myriad of possible binary representations, so please submit a new PR if you want this issue to be fixed in a better way.

Thanks, and sorry for the hassle.

@m6w6 m6w6 closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants