Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 2 support #518

Closed
sblondon opened this issue Sep 4, 2022 · 2 comments · Fixed by #519
Closed

Drop Python 2 support #518

sblondon opened this issue Sep 4, 2022 · 2 comments · Fixed by #519
Milestone
1.1

Comments

@sblondon
Copy link
Contributor

sblondon commented Sep 4, 2022

According to pypi page, the python2 support has been dropped with release 1.0.
The main branch in the repository is currently v.1.0.4 release (https://github.com/msgpack/msgpack-python/blob/main/msgpack/__init__.py#L9).

However, there is python2 specific code in the repository. For example:

  • setup.py checks for python2
  • msgpack/fallback.py could be simplified
  • python2 is checked in tox.ini
  • test/test_timestamp.py skip some tests with python2 (@pytest.mark.skipif(sys.version_info[0] == 2) ; test/test_extension.py has also a conditional

Are you interested by a PR to remove them?
@methane
Copy link
Member

methane commented Sep 9, 2022

According to pypi page, the python2 support has been dropped with release 1.0.

image

Read it again.

@methane methane closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2022
@methane
Copy link
Member

methane commented Sep 9, 2022

Are you interested by a PR to remove them?

pip dropped Python 2 support. So I will drop it too.
I don't have actual plan for msgpack 1.1 or 2.0. But PR to remove them is welcome.

@methane methane reopened this Sep 9, 2022
@methane methane changed the title python2 code in the repository Drop Python 2 support Sep 9, 2022
@sblondon sblondon mentioned this issue Sep 11, 2022
Merged
@methane methane added this to the 1.1 milestone May 21, 2023
methane added a commit that referenced this issue May 21, 2023
@sblondon @methane
Drop python2 support (#519)
feec062 
The PR removes python2 references and cases.

Close #518

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Drop python2 support
2 participants
@methane @sblondon