Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended type support #14

Closed
wants to merge 22 commits into from
Closed

Extended type support #14

wants to merge 22 commits into from

Conversation

ramonmaruko
Copy link

My C is not really good, so please review this properly. Thank you.

@ramonmaruko
Copy link
Author

Bump. Any code reviews for this are very welcomed.

@CodeMonkeySteve
Copy link

Your code looks good, but it would be really nice if the interface could instantiate Ruby objects by type instead of Extension objects, e.g.:

class CustomType
  MessagePack.register_extension(42, self) 
  def self.from_msgpack(data)
    CustomType.new(...)
  end
end

@sardaukar
Copy link

+1 for a nicer interface, please

@alexgenco alexgenco mentioned this pull request Nov 10, 2014
Closed
@ramonmaruko
Add write_ext_header
be6fd43
@ramonmaruko
Add write_ext_value
ce854f9
@ramonmaruko
Add unpacking of Extensions
bf74336
@ramonmaruko
Move fixext n condition outside case statement
c667b7b
@ramonmaruko
Add C MessagePack::Extended class
10e580a 
* Remove Ruby MessagePack::Extended class
* Move delegete_to_pack and ENSURE_PACKER to packer_class.h
* Make msgpack_packer_write_ext_value access the instance methods `type` and
  `data` instead of just instance variables.
@ramonmaruko
Extract read_extended_body_begin
1c599b7
@ramonmaruko
Fix: packing ext type is returning 0
a734997
@ramonmaruko
Check for type range error during init
314adc9
@ramonmaruko
Add spec checking for packed result
0fc0540
@ramonmaruko
Add parenthesis to remove ambiguity
5f906e6
@ramonmaruko
Rename Extended_to_eql to Extended_eql
6c5a0b0
@ramonmaruko
Check for sameness of class for Extended.eql?
4dc3035
@ramonmaruko
Add and use Extended#create for ext generation
83e41b4 
This lets the users override Extended#create to handle the
deserialization of application specific extended types.
@ramonmaruko
Use the approriate integer types for var ext head
22b8be4
@ramonmaruko
Add type setter for Extended
1e3ec6b
@ramonmaruko
Fix: read_raw_body_begin signature change (0.5.7)
43de62d
@ramonmaruko
Use rb_funcall instead of manually creating argv
4e1d2f6
@ramonmaruko ramonmaruko reopened this Apr 12, 2015
@ramonmaruko
Copy link
Author

Sorry if it took me too long to implement ::register_extension. I was busy with other things.

@sardaukar
Copy link

Great work, thanks!

@ramonmaruko ramonmaruko mentioned this pull request Apr 12, 2015
Closed
@tagomoris tagomoris mentioned this pull request May 28, 2015
Closed
@tagomoris
Copy link
Member

My review results are:

  • ext type information should be for packer/unpacker instances, not runtime global

Now we should consider about JRuby implementation...

@ramonmaruko
Copy link
Author

Seems like this isn't needed anymore since #71 is already here.

@ramonmaruko ramonmaruko closed this Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ramonmaruko @CodeMonkeySteve @sardaukar @tagomoris