Better fix for marking buffers held on the stack #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup: msgpack#347 As discussed previously, the `alloca` hack was just a quick fix, it's not good as it could lead to stack overflows and also could be optimized away by compilers etc. Here instead we copy all the VALUE references into a dedicated object that is in change of holding and pinning these references.
casperisfine
force-pushed
the
better-buffer-stack-fix
branch
from
c05999d
to
e4ca627
Compare
peterzhu2118
approved these changes
Jul 17, 2023
|
Thanks! I was thinking maybe we can just use a msgpack Buffer to hold onto the struct and the VALUEs inside. |
Yeah that doesn't. The From what I could gather, it's an optimization to avoid pointer chasing when you append to the buffer, but it's unclear how efficient that really is. We talked with @peterzhu2118 about potentially simplyfing the buffer implementation, but not sure when we'll actually get around it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #347
As discussed previously, the
allocahack was just a quick fix, it's not good as it could lead to stack overflows and also could be optimized away by compilers etc.Here instead we copy all the VALUE references into a dedicated object that is in change of holding and pinning these references.
cc @peterzhu2118 @eregon @pavel-workato @sitano