Fix test suite on platforms without compaction support #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
handle-missing-compaction
branch
from
7d7bdef
to
2501bb6
Compare
byroot
approved these changes
Nov 21, 2023
|
Hi, I noted in #354 that this seemed the obvious fix to me and so I had already tried it, but this commit causes the test suite to hang. Output is just: and then it spins chewing one CPU core. |
|
If you remove the If so I'm happy to take a PR that detect your environment and just skips this part. |
Hmmm, no it still hangs, so this must not be the cause. I provide free shell access to all of the machines I use to reproduce these bugs on, would this be useful to look into it? |
I might if I have time to kill. In the meantime, what happens if you send a SEGV signal? That should trigger the ruby crash report and give you a C-backtrace of where ruby is hanging. |
|
|
Thanks, ok so this is very weird. It's literally stuck loading the code, it hasn't even started the test suite yet. I really have little idea what it could be. |
|
Recompiled everything with -O0, debug assertions, etc. Slightly better backtrace here - the exact line varies slightly depending on when I stop it, but everything up to the top 2 frames or so is consistent. |
|
Well...interesting discovery, everything works on Ruby 3.2! |
|
Interesting backtrace. I wonder if somehow it's a Ruby 3.1 GC bug (e.g. @peterzhu2118 does that ring any bell? But good news on 3.2 working! |
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 22, 2023
See: msgpack/msgpack-ruby#355 Bug: https://bugs.gentoo.org/917362 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 22, 2023
See: msgpack/msgpack-ruby#355 Bug: https://bugs.gentoo.org/917362 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 23, 2023
See: msgpack/msgpack-ruby#355 Bug: https://bugs.gentoo.org/917362 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 23, 2023
See: msgpack/msgpack-ruby#355 Bug: https://bugs.gentoo.org/917362 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #354