Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the spec document be given a version? #162

Closed
cforger opened this issue Jan 15, 2014 · 6 comments · May be fixed by #165
Closed

Can the spec document be given a version? #162

cforger opened this issue Jan 15, 2014 · 6 comments · May be fixed by #165

Comments

@cforger
Copy link

cforger commented Jan 15, 2014

Hello,

Thanks for your work on MessagePack.

While trying to figure out what msgpack libraries are compatible (between Python and JavaScript for example), I find it rather difficult because this document does not have a version on it.

The messagepack.org site mentions v5 when it links here, but I don't see that on the document.

Without a clearly defined version variable in the specification document, you can't look at different source libraries and know that they will support 'Version 3' of the msgpack spec, etc.

Additionally, a changelog would be very useful - There doesn't seem to be much history here, so when I look at a library that is 3 years old, I can't find what spec they were writing to conform to, which adds to my work to update that library.

Thanks.
jodastephen added a commit to jodastephen/msgpack that referenced this issue Jan 27, 2014
@jodastephen
Provide version numbers for the old and new specifications
f7bb108 
Providing version numbers is good software practice.
This change will be appreciated by all users of MessagePack.
Fixes msgpack#162
@jodastephen jodastephen mentioned this issue Jan 27, 2014
Open
@nonchip
Copy link

nonchip commented Aug 13, 2014

why is this still open? seems resolved in f7bb108

@pythontech
Copy link

The referenced commit does not appear to be present in the current git repository. Neither "1.0" nor "2.0" appears in the current spec.md or spec-old.md files.

@nonchip
Copy link

nonchip commented Aug 28, 2014

that's because #165 wasn't merged (yet), I guess.

@pythontech
Copy link

@frsyuki and friends, please please please provide version numbers for the spec, e.g. by merging
f7bb108
The current situation is confusing and does discredit to the project. I and the OP are not the only ones confused - the C implementation https://github.com/camgunz/cmp returns 5 as the msgpack version.

@cforger
Copy link
Author

cforger commented Jan 17, 2015

Thought I'd check in a year later - Sad to see it's still open, but happy to see others taking up the cause.

It's such a simple thing, but oh so useful.

This is a major hurdle for adoption for anyone wanting to use MsgPack across different languages. I'm sure there are lots who are just giving up, and going back to JSON or BSON, because who has time to try and figure out where each language implementation left off in applying the specification?

@methane methane mentioned this issue Apr 1, 2015
Closed
@xor-gate xor-gate mentioned this issue Apr 10, 2015
Open
@kuenishi
Copy link
Member

Discussion is going on at #195.

If you wonder wether new spec is supported at the library of your language, it'd be good to open an issue at that repository and ask questions. That is usually because library maintainer is not good at documentation, stating things, or maintainers are not well organized. ... please ask. I think for C library, which looks like what you care, the new spec was introduced at 0.5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide version numbers for the old and new specifications jodastephen/msgpack
3 participants
@kuenishi @nonchip @cforger