Feature More support for Python 3 and mixed Python 2, 2+3 and 3 #25

bennygomspace · 2018-12-14T09:23:34Z

Stuff relevant primary during migration to Python 3 added

Added checkers:
** pylint-py3k (Command: pylint --py3k)
** pylint3
Autodection if a file shall be checked with a subset of the specifed checkers:
** Python 2 compatible checkers
** Python 3 compatible checkers
** Both Python 2 and 3 compatible checkers
There will never be checked with checkers not specified via arg --checkers or in CHECKERS=... in config file.

Autodection is only active if enabled via arg --py23-autodetect or PY23_AUTODETECT = 1 in config file

I think it is relevant to also check with pylint3 while preparing and during migration from Python 2 to 2+3 or 3. pylint --py3k might also show some things to fix, so that have also been added. Option pylint_rcfile is common for all pylint* commands, just as for mypy*. Note: README.md is updated manually, since generating it using el2markdown, generates a lot of changes.

The autodect is performed via checking python version in #!/... line or a # py:<version, e.g. '2', '23', '3'> line. See README.md for details.

msherry

This is really nice, thank you! A couple of suggested changes, but overall I like the direction this is going.

msherry · 2018-12-19T23:33:32Z

bin/pycheckers.py

@@ -535,6 +537,30 @@ def process_returncode(self, returncode):
        return not (returncode & 1 or returncode & 32)


+class PylintPy3kRunner(PylintRunner):
+    """Run pylint --py3k, producing flymake readable output.


I know it's copied from existing checkers (that I need to fix!), but can we change "flymake" to "flycheck"?

msherry · 2018-12-19T23:33:57Z

bin/pycheckers.py

+
+
+class Pylint3Runner(PylintRunner):
+    """Run pylint3, producing flymake readable output.


Same here, s/flymake/flycheck/.

msherry · 2018-12-19T23:34:27Z

bin/pycheckers.py

+    '''
+    Check if first line says python/python2/python3 => Activate py2/3 checkers
+
+    Can be overruled via a line: # py:<version>


Interesting! Is this a common convention, or just something you decided?

msherry · 2018-12-19T23:34:39Z

bin/pycheckers.py

+    Check if first line says python/python2/python3 => Activate py2/3 checkers
+
+    Can be overruled via a line: # py:<version>
+    If <version> contains 2 -> then set py2 (1th return value)


Nit: "1st" instead of "1th".

msherry · 2018-12-19T23:35:07Z

bin/pycheckers.py

@@ -753,11 +787,63 @@ def update_options_locally(options):
    return options


+def py2_py3_enable(py23_autodetect, source_file_path):
+    # type: (str) -> bool, bool


This type signature looks wrong -- there are two parameters, but only one input type.

sorennohr · 2019-02-18T07:49:15Z

#####################################
Subject: Review of flycheck-pycheckers pull #25
Hi Marc

#25

Unfortunate Benny can't make the changes.
If you can make the changes, it will be great!

It's fine with us to:

s/flymake/flycheck/g (twice)
s/1th/1st/
Auto-detection: See below
Add 1st input bool:
type: (bool, str) -> bool, bool

Auto-detection
1st line
The auto detection if the first line is a simple matching for both
#!/path/to/pythonX and #!/usr/bin/env pythonX - any other pythonX
where X can be empty, 2 or 3.
The check is made simple, so bad #! formatted lines are recognized.

py:

The # py: was not found elsewhere, actually we have not found any checking-help for python2-> 2+3 or 3 migration. (2to3 and futurize can modify the code but not show mistakes (well)).

The background was:
Space after # to let checkers be happy (some rules claims if space after # is missing)
py: Just a short identifier
could be stricter checking, but a simple search for 2 and 3

bennygomspace added 2 commits December 14, 2018 09:43

Autodetect src => select checkers (for Migrate python 2 to 2+3 or 3)

b34b776

The autodect is performed via checking python version in #!/... line or a # py:<version, e.g. '2', '23', '3'> line. See README.md for details.

msherry reviewed Dec 19, 2018

View reviewed changes

msherry force-pushed the master branch 2 times, most recently from e64d6cd to e588b5f Compare December 28, 2018 02:32

GomSpace closed this by deleting the head repository Sep 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature More support for Python 3 and mixed Python 2, 2+3 and 3 #25

Feature More support for Python 3 and mixed Python 2, 2+3 and 3 #25

bennygomspace commented Dec 14, 2018

msherry left a comment

msherry Dec 19, 2018

msherry Dec 19, 2018

msherry Dec 19, 2018

msherry Dec 19, 2018

msherry Dec 19, 2018

sorennohr commented Feb 18, 2019

type: (bool, str) -> bool, bool



		class Pylint3Runner(PylintRunner):
		"""Run pylint3, producing flymake readable output.

Feature More support for Python 3 and mixed Python 2, 2+3 and 3 #25

Feature More support for Python 3 and mixed Python 2, 2+3 and 3 #25

Conversation

bennygomspace commented Dec 14, 2018

msherry left a comment

Choose a reason for hiding this comment

msherry Dec 19, 2018

Choose a reason for hiding this comment

msherry Dec 19, 2018

Choose a reason for hiding this comment

msherry Dec 19, 2018

Choose a reason for hiding this comment

msherry Dec 19, 2018

Choose a reason for hiding this comment

msherry Dec 19, 2018

Choose a reason for hiding this comment

sorennohr commented Feb 18, 2019

type: (bool, str) -> bool, bool

py: