Add update-only configuration option
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahatzz11
force-pushed
the
add-update-only-configuration
branch
from
ec8b20b
to
9c49af4
Compare
ahatzz11
changed the title
update-only configuration option
mshick
approved these changes
May 2, 2023
|
@ahatzz11 This looks good to me. Nice work and thanks for the contribution! |
|
@all-contributors please add @ahatzz11 or code |
|
I've put up a pull request to add @ahatzz11! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
update-onlyconfiguration option, which allows a run of theadd-pr-commentto do nothing if a comment with a matching comment-id doesn't exist.p.s. I'm a frontend noob and I don't think I've ever written a frontend test in my life. I played with both positive and negative test cases and I think it all works properly, but figured I'd mention it to get an extra set of eyes on this PR.
Closes #87
Edit: I don't really understand why there are +5k/-13k changed lines here, I think it has to do with the
package-lock.json. I'm not really sure if I did something wrong here, so let me know if I should do anything to clean this up.