Skip to content

Commit

Permalink
disable new babel plugins
Browse files Browse the repository at this point in the history
  • Loading branch information
mshustov committed Jun 9, 2020
1 parent e98c40a commit 04d9594
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions packages/kbn-babel-preset/common_babel_parser_options.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ module.exports = {
plugins: [
'asyncGenerators',
'classProperties',
'classPrivateProperties',
'classPrivateMethods',
// 'classPrivateProperties',
// 'classPrivateMethods',
'dynamicImport',
'exportDefaultFrom',
'exportNamespaceFrom',
// 'exportNamespaceFrom',
'objectRestSpread',
'throwExpressions',
],
Expand Down
12 changes: 6 additions & 6 deletions packages/kbn-babel-preset/common_preset.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ const plugins = [
// Need this since we are using TypeScript 3.7+
require.resolve('@babel/plugin-proposal-nullish-coalescing-operator'),

// Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from)
// Need this since we are using TypeScript 3.8+
require.resolve('@babel/plugin-proposal-export-namespace-from'),
// // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from)
// // Need this since we are using TypeScript 3.8+
// require.resolve('@babel/plugin-proposal-export-namespace-from'),

// Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from)
// Need this since we are using TypeScript 3.9+
require.resolve('@babel/plugin-proposal-private-methods'),
// // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from)
// // Need this since we are using TypeScript 3.9+
// require.resolve('@babel/plugin-proposal-private-methods'),
];

module.exports = {
Expand Down
6 changes: 3 additions & 3 deletions src/core/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class Server {
private readonly status: StatusService;
private readonly coreApp: CoreApp;

#pluginsInitialized?: boolean;
private pluginsInitialized?: boolean;
private coreStart?: InternalCoreStart;

constructor(
Expand Down Expand Up @@ -179,7 +179,7 @@ export class Server {
};

const pluginsSetup = await this.plugins.setup(coreSetup);
this.#pluginsInitialized = pluginsSetup.initialized;
this.pluginsInitialized = pluginsSetup.initialized;

await this.legacy.setup({
core: { ...coreSetup, plugins: pluginsSetup, rendering: renderingSetup },
Expand All @@ -198,7 +198,7 @@ export class Server {
const elasticsearchStart = await this.elasticsearch.start();
const savedObjectsStart = await this.savedObjects.start({
elasticsearch: elasticsearchStart,
pluginsInitialized: this.#pluginsInitialized,
pluginsInitialized: this.pluginsInitialized,
});
const capabilitiesStart = this.capabilities.start();
const uiSettingsStart = await this.uiSettings.start();
Expand Down
6 changes: 3 additions & 3 deletions src/dev/i18n/extractors/code.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ export function* extractCodeMessages(buffer, reporter) {
'typescript',
'objectRestSpread',
'classProperties',
'classPrivateProperties',
'classPrivateMethods',
// 'classPrivateProperties',
// 'classPrivateMethods',
'asyncGenerators',
'dynamicImport',
'nullishCoalescingOperator',
'optionalChaining',
'exportNamespaceFrom',
// 'exportNamespaceFrom',
],
});
} catch (error) {
Expand Down

0 comments on commit 04d9594

Please sign in to comment.