Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added short options for easy commandline use #73

Merged
merged 2 commits into from
Mar 26, 2018

Conversation

wolph
Copy link
Contributor

@wolph wolph commented Mar 26, 2018

No description provided.

Copy link
Owner

@msiemens msiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small question 🙂

PyGitUp/gitup.py Outdated
@@ -580,12 +580,13 @@ def print_error(self, error):


@click.command(epilog=EPILOG)
@click.option('--version', is_flag=True,
@click.option('--version', '-v', is_flag=True,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In many cases -v means verbose and -V means version (for example with the Python interpreter), so this may confuse some people. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that's probably better :)

I suppose I was on autopilot a bit, I'll change it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done :)

@msiemens msiemens merged commit 2e43568 into msiemens:master Mar 26, 2018
@msiemens
Copy link
Owner

Awesome, thanks 🙂 I'll try to release a new version of PyGitUp next week or the week after

@msiemens
Copy link
Owner

msiemens commented Apr 7, 2018

This is now released in v1.4.7 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants