Add Python 3 support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, great work @r4ts0n! I think we could even release PyGitUp 2.0 after merging this. One minor thing: Could also update the Python 3 compatibility paragraph in the readme? (And have you any idea why the Travis tests didn't run? It's not a problem, I'm just wondering) |
|
Updated README to reflect the Python 3 support. |
|
Thank you, @r4ts0n! I'm currently on vacation and thus will propably release PyGitUp v2.0.0 next week :) |
|
Quick note: I decided to take a more conservative approach in regards to versioning and release this change as v1.3.0. This is also closer to semantic versioning as there haven't been any breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the excellent
sixlibrary to support both Python 2 and 3.All tests passes on my machine for Python 3.4.3 and 2.7.9