Drop the click dependency #96
Conversation
|
Looks like 3.4 failed because the env is no longer available. |
|
#99 drops 3.4 |
|
Rebased on master |
See msiemens/PyGitUp#96 Package-Manager: Portage-3.0.18, Repoman-3.0.3
|
Hey @ekohl, sorry for never getting back to you on this! I've always procrastinated responding to this PR as I'm torn on the question whether or not having Click as a dependency is worth it. On the one hand, we don't use most of Click's advanced features like subcommands and fancy argument parsing. But on the other hand, to me depending on the extra code has never bothered me too much. Anyways, thinking about this I don't see any good reason to keep using Click if we don't need the extra features. @ekohl Could you rebase this unto the latest version of PyGitUp so we can get this merged? |
This reduces the number of external dependencies and relies more on Python's standard library. It drops the --no-push option since argparse doesn't support having a --option / --no-option. That's also the default and this makes it clearer to the user what the default is. The help text's formatting is slightly different. Mostly visible are that the description and epilog are no longer indented.
ekohl
force-pushed
the
drop-click-dep
branch
from
be8e2cc
to
484faf1
Compare
|
Better late than never. Having been a long time open source maintainer I know what goes through your head. My main motivation was easier packaging. I prefer to install my tooling as RPMs and fewer dependencies makes that easier. I've rebased it now. I hand edited the poetry.lock file and I hope it's ok, but I've never used poetry myself. |
|
Thanks a lot! I'll publish a new release of PyGitUp in a second 🙂 |
This reduces the number of external dependencies and relies more on Python's standard library.
It drops the --no-push option since argparse doesn't support having a --option / --no-option. That's also the default and this makes it clearer to the user what the default is.
The help text's formatting is slightly different. Mostl visible are that the description and epilog are no longer indented.