New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TinyDB class for subclassing #150

Merged
merged 1 commit into from Aug 30, 2017

Conversation

2 participants
@ASMfreaK
Contributor

ASMfreaK commented Aug 29, 2017

I want to be able to do something like this:

from tinydb import TinyDB
from tinydb.middlewares import CachingMiddleware
class YamlStorage(...):
    ...

class CachingYamlTDB(TinyDB):
    DEFAULT_STORAGE = CachingMiddleware(YamlStorage)

This PR enables TinyDB for such sublassing.

@msiemens msiemens merged commit a51234c into msiemens:master Aug 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.757%
Details
@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Aug 30, 2017

Owner

That makes sense, thanks for the contribution!

Owner

msiemens commented Aug 30, 2017

That makes sense, thanks for the contribution!

@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Aug 30, 2017

Owner

Now released in v3.5.0 🎉

Owner

msiemens commented Aug 30, 2017

Now released in v3.5.0 🎉

@ASMfreaK

This comment has been minimized.

Show comment
Hide comment
@ASMfreaK

ASMfreaK Aug 30, 2017

Contributor

Yay~
Thanks)

Contributor

ASMfreaK commented Aug 30, 2017

Yay~
Thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment