Write to a temporary file and rename to avoid damage in case of crash

[ostafen]

PR for #467

[ostafen]

@msiemens Any update on this?

[msiemens]

Hey @ostafen, I've been busy the last couple of weeks, I'll get back to this before the end of this week!

[ostafen]

Ok, thank you for the update 👍 I'm here for any kind of feedback

[msiemens]

After merging this I've added Windows tests for TinyDB and it turns out that os.rename doesn't work on Windows when the destination file already exists (https://github.com/msiemens/tinydb/runs/6561237986?check_suite_focus=true) 🙈 I think I fixed it by adapting some code from https://github.com/untitaker/python-atomicwrites/ but the tests are still running.

It's not your fault that this went unnoticed, I think when you created your PR the CI configuration had an error so that it didn't run on Pull Requests. And even if it did, there were no Windows CI pipelines configured. So this one is on me 🙂

I'll revert the changes for now and try to get this to work on a Windows machine so we can get this feature back in!

[msiemens]

think I fixed it by adapting some code from https://github.com/untitaker/python-atomicwrites/ but the tests are still running.

The tests have run now and they fail even with my workaround: https://github.com/msiemens/tinydb/runs/6561403728. I'll try to take a deeper look soon!