Integrate with pkgdb

[jasontibbitts]

So that the number of interfaces a maintainer must use to set up their packages stays reasonable, it would be really nice to integrate koschei with a knob in pkgdb which turns on the monitoring. I'm filing this ticket to start the conversation on the possibility of making that happen.

[ralphbean]

/cc @ralphbean, @pypingou, @nirik

[pypingou]

So we would have a switch on the package page to add support for koschei?

That would be unrelated to the Monitoring (for new updates) flag, right?

[mizdebsk]

@pypingou Yes, that's how I understand that feature. Instead of adding package in Koschei you could add it directly from pkgdb2 by toggling boolean, just like you enable release monitoring.

[remicollet]

+1

[pypingou]

Ok I have the changed made on the pkgdb side, this is how it would look:

Then the list of packages will be exposed via a similar API than:
https://admin.fedoraproject.org/pkgdb/api/#list_packages_monitored

And changes in the status will be announced via fedmsg

[ralphbean]

@pypingou now that there are two headers on the right panel ("monitoring" and "koschei integration"), there should probably be a third header titled "other stuff". Right now it looks like "request new branch" has something to do with koschei.. which it does not.

[pypingou]

Yes, I was thinking the same, just not sure what the right header would be Actions?

[mizdebsk]

Changes that would need to be implemented at Koschei side:

• koschei-watcher should watch for package.koschei.update messages and update database accordingly
• koschei-polling should periodically sync list of monitored packages with pkgdb2's /api/koschei (or /api/koschei?format=json for JSON) - fallback method needed due to unreliable nature of fedmsg
• packages blocked in Koji must remain marked as ignored
• pkgdb2 integration needs to remain optional, so this feature must be possible to be disabled in config
• with this feature enabled, it shouldn't be possible to add packages through web nor CLI interface

[mizdebsk]

It's all implemented and can be tested in staging:

• https://apps.stg.fedoraproject.org/koschei/
• https://admin.stg.fedoraproject.org/pkgdb/

Changes in package DB should be immediately seen by Koschei.

[jasontibbitts]

Awesome! Thanks. I imagine that pushing this to production will miss the freeze deadline but I look forward to seeing this more widely implemented.

I would, however, recommend a tooltip or something, since many folks won't have any idea as to what koschei actually is.

[pypingou]

There is one fix needed for pkgdb before we're ready, I can do it today and cut the release.

When do we want to push to prod? (I'm ok with tomorrow or Monday)

[pypingou]

pkgdb2 is updated and deployed in stg

[mizdebsk]

When do we want to push to prod?

I would like to deploy current Koschei to production ASAP, but this is blocked by infra tickets #4878, #4879 and rel-eng ticket #6172.

[nirik]

Well, those are all stg issues... but yeah, I hope to get time to work on some of them over the next few weeks that we are in freeze.

[nirik]

I've fixed the infra tickets now. Do you need 6172? I can ask Dennis again later this week, but he is traveling now...

[mizdebsk]

I've fixed the infra tickets now.

Thank you.

Do you need 6172? I can ask Dennis again later this week, but he is traveling now...

Yes. There were multiple improvements in the way Koschei communicates with Koji. Testing them properly requires either cooperation with staging Koji admins, or one of Koschei developers becoming Koji admin. Without that some features will have to go to production without prior testing in staging.