-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid XML in generated reports #190
Comments
There are reports containing broken XML, e.g. the ones created by Mail::DMARC, see msimerson/mail-dmarc#190
Note: The Database schema (for mysql at least) specifies 'CHARACTER SET ascii', so this will need to be updated to handle the storage of UTF-8 in reports. |
Sounds like the right choice, based on my read of RFC 8616.
True, but will it matter? New reports will be saved with the new converted a-label form, which should fix all future reports, and solve this issue, right? RFC 8616, Section 6
|
Because the data column that stored domains and author info were explicitly declared as ASCII, I think (limited testing) that mysql would have converted any unicode characters to a Now that MySQL 8 is the minimum supported version, changing the schema to enable UTF-8 chars is no longer messy and fraught with pitfalls. The SQL code shown on the mysql wiki page should do the needful. |
Describe the bug
The user-configured org_name (at least) is taken as-is for XML and mail message bodies, but people tend to enter characters that are not suitable as-is in neither.
Examples:
Message Body:
Corresponding XML:
Also in a more recent version (and this time already the message body is showing signs of breakage, too)
and XML:
When trying to view this report in Firefox it complains:
Other XML parsers complain or fail as well.
Note: I'm not an active user but suffer from the XML that gets send by Mail::DMARC on the receiving end that is not being processed by XML parsers because of this. I haven't got a report showing this issue sent by the latest version, but by the looks of it this is still the case in the current code.
The text was updated successfully, but these errors were encountered: