Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several issues in file search functions #231

Closed
mpurg opened this issue Mar 21, 2024 · 0 comments · Fixed by #232
Closed

Several issues in file search functions #231

mpurg opened this issue Mar 21, 2024 · 0 comments · Fixed by #232

Comments

@mpurg
Copy link

mpurg commented Mar 21, 2024

Hi,

I noticed a few non-critical issues in the find_psl_file and get_config functions:

  1. The variable $path is referenced outside the foreach loop and is thus uninitialized, thus the following will never be true:

    if ($path && -r $path) {

  2. The default value for $file is share/public_suffic_list while at the same time, get_prefix is called with the prefix share/, resulting in .../share/share/... paths, which is probably not intended.

  3. In get_config , the config file is first read from CWD without checking ownership/permissions, which could be a security issue.

msimerson added a commit that referenced this issue Mar 21, 2024
msimerson added a commit that referenced this issue May 31, 2024
- remove t/travis/.travis.yml CI config file, partial fix for #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant