apply patches in issues #129 and #124 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2018
msimerson
changed the title
README.md
Outdated
|
|
||
| ## Easy to use | ||
|
|
||
| Providing an implementation of DMARC that SMTP utilities like SpamAssassin, amavis, and qpsmtpd can consume is expected to increase adoption. | ||
| The effectiveness of DMARC will improve significantly as adoption increases. Proving an implementation of DMARC that SMTP utilities like SpamAssassin, amavis, and qpsmtpd can consume will aid adoption. |
There was a problem hiding this comment.
Should that read providing rather than proving?
bin/dmarc_send_reports
Outdated
| @@ -375,7 +375,7 @@ sub email { | |||
| }); | |||
| $smtp->quit; | |||
| return; | |||
| } | |||
| }; | |||
There was a problem hiding this comment.
Doesn't appear necessary
bin/dmarc_send_reports
Outdated
| else { | ||
| $report->store->error($rid, $err); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
lines 414/415 terminating ; not necessary
|
A couple of comments made, generally looks good to me. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #129
fixes #124
fixes #123
fixes #121