Export REDIS_URL when enabling/starting Redis #8
Conversation
|
I see :) Will merge soon! |
|
Great :) |
|
But is it not possible (in the Ruby world) to craft the REDIS_URL variable inside the bootstrapper / application logic? I think its best if I just exposed default Docker Link variables and let the applications suit themselves to it, to keep the plugin simple and as non language/library specific as possible. Or just use the provided env variable names by specifying the host and port explicitly to the Redis connector by getting the env variables? |
|
Yes it’s possible just it requires no configuration if REDIS_URL is set: https://github.com/redis/redis-rb :) |
|
I’ll check if other redis libraries (for other languages) uses REDIS_URL or not |
|
Well it seems REDIS_URL is quite ruby oriented but to have a database url is much more heroku-like. Python package seems to support it since about 3 years: redis/redis-py#246 |
|
Sounds good, but I'll just move the config to start instead of enable since resetting of that variable is expected on a rebuild. |
|
Hello, please look at #10. I've moved the config setting to :start so it gets reset on rebuilds. Apart from that, looks good. |
Export REDIS_URL when enabling/starting Redis. Fixes #8
|
Ok thanks :) I moved the variable from start to enable because start is called in pre-deploy I think. And when you set an ENV variable in dokku, it automatically restarts the app so when deploying your application it restarts twice (IIRC). |
|
Yeah, I'm fixing it right now by custom implementing the config set without the restart. Will let you know when that's committed. |
|
Ok great! |
|
Nevermind. What I have on master won't work. I had to separate pre-release and pre-deploy so that env variables are set at pre-release but redis is started at pre-deploy (for it to start on reboots.) Just tested it like this and it works. I will clean up and commit this to master. |
|
Ok thank you :) |
|
Done. I should probably start tagging commits... |
|
Yes I think you’re right :) |
Since this plugin is using docker links, it’s really easy to export a complete URL for Redis that will not change too often. And REDIS_URL seems to be used as a standard to set connection to the Redis server in various libraries (at least in the Ruby world ;)).