Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter to show all runs while linking #54

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

nikhil
Copy link
Member

@nikhil nikhil commented Oct 17, 2022

No description provided.

@nikhil nikhil requested a review from buehlere October 17, 2022 22:54
Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me help take a look. I was a little concerned about what would happen for failed runs without any files, but to my understanding this block should account for that case?

except Exception as e:
print("Could not create symlink from '{}' to '{}'".format(sample_version_path / file_name, file_path), file=sys.stderr)
continue
try:
os.unlink(sample_path / "current")
except Exception as e:
pass
try:
os.symlink(sample_version_path.absolute(), sample_path / "current")
except Exception as e:
pass
Otherwise looks good to me!

@buehlere buehlere merged commit a6a1c4c into develop Nov 8, 2022
@nikhil nikhil mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants