Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NF PR in order to fix memory issue #65

Closed
evanbiederstedt opened this issue Mar 21, 2019 · 2 comments
Closed

NF PR in order to fix memory issue #65

evanbiederstedt opened this issue Mar 21, 2019 · 2 comments
Labels
bug Something isn't working enhancement New feature or request
Projects
Manhattan
Milestone
0.6.0

Comments

@evanbiederstedt
Copy link
Contributor

evanbiederstedt commented Mar 21, 2019 •
edited

nextflow-io/nextflow#1035

Recall that Philip found (and mentioned on gitter) that Nextflow was assuming that LSF is configured to fundamentally use MB as the unit for job submissions.

This is wrong. (A) Users set this to whatever they want and (B) on site for juno, we use GB.

The following should fix this issue.
@evanbiederstedt evanbiederstedt created this issue from a note in Manhattan (Backlog) Mar 21, 2019
@evanbiederstedt evanbiederstedt added bug Something isn't working enhancement New feature or request labels Mar 21, 2019
@allanbolipata allanbolipata moved this from Backlog to To do in Manhattan Mar 27, 2019
@sivkovic sivkovic added this to the 0.5.0 milestone Mar 27, 2019
@sivkovic sivkovic modified the milestones: 0.5.0, 0.6.0 Apr 3, 2019
@evanbiederstedt evanbiederstedt moved this from To do to In progress in Manhattan Apr 4, 2019
@evanbiederstedt evanbiederstedt changed the title Finish up the NF PR already, Evan NF PR in order to fix memory issue Apr 10, 2019
@evanbiederstedt
Copy link
Contributor Author

So many files changed in the PR from last month, I've become confused at how to isolate the tests properly. So, I'm starting over.

I'll discuss with @sivkovic how to configure things properly.

@evanbiederstedt
Copy link
Contributor Author

Oh yeah

nextflow-io/nextflow#1035 (comment)

The reason I stopped working on this was that Paolo told me via e-mail last month he was working on this

@allanbolipata allanbolipata moved this from In progress to Done in Manhattan Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
Manhattan
  
Done
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@evanbiederstedt @sivkovic