fix thread-safe zerolog usage, details rs/zerolog#242 and https://git…

…hub.com/rs/zerolog/blob/master/README.md?plain=1#L431
mskwon · Jun 14, 2023 · c20eeb0 · c20eeb0
1 parent 50bce08
commit c20eeb0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/clickhouse/clickhouse.go b/pkg/clickhouse/clickhouse.go
@@ -909,10 +909,12 @@ func (ch *ClickHouse) SelectSingleRowNoCtx(dest interface{}, query string, args
 
 func (ch *ClickHouse) LogQuery(query string, args ...interface{}) string {
 	var logF *zerolog.Event
+	// zerolog is not thread-safe https://github.com/rs/zerolog/issues/242 ;(
+	logger := ch.Logger.With().Logger()
 	if !ch.Config.LogSQLQueries {
-		logF = ch.Logger.Debug()
+		logF = logger.Debug()
 	} else {
-		logF = ch.Logger.Info()
+		logF = logger.Info()
 	}
 	if len(args) > 0 {
 		logF.Msg(strings.NewReplacer("\n", " ", "\r", " ", "\t", " ").Replace(fmt.Sprintf("%s with args %v", query, args)))