Some details noted #16
Conversation
Signed-off-by: <Michael Heltne michael.heltne@gmail.com>
| // Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: | ||
| // Copyright (c) 2013, The Linux Foundation. All rights reserved. (FIXME) | ||
| /* | ||
| * SPDX-License-Identifier: GPL-2.0-only |
There was a problem hiding this comment.
The SPDX-License-Identifier should be a // comment, see https://www.kernel.org/doc/html/latest/process/license-rules.html#license-identifier-syntax
For the other Copyright text it varies in the kernel tree. Most are using /* ... */, but there are also some which are not, see e.g. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c
So I think it might be fine to keep this as-is. What do you think?
There was a problem hiding this comment.
Ah yes, that SPDX as // struck me around the time i hit the pillow. Well, I'm two phased there, perhaps it's a good idea to encourage people to get to know the script a little and edit as needed as nothing can be guaranteed as perfect, but on the other hand, just grabbing it, generating a panel file and then just editing the output a bit would be optimal as well.
Cheers and thanks for all the panel drivers!
threader
force-pushed
the
details
branch
2 times, most recently
from
5d3795c
to
673e435
Compare
but the original generated example i cant find??? Signed-off-by: <Michael Heltne michael.heltne@gmail.com>
|
I edited the readme a bit, i'm not sure i'm happy with the last one just yet, and i'll be staring (at goats) until i understand for a while longer. Got any suggestions? I look at it and want to shorten down so it fits with the rest, but that's OCD. |
threader
changed the title
So I thought it might be nice if the headers comply with coding conduct for the kernel?