Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memshare service for GPS #158

Merged
merged 15 commits into from Mar 12, 2021
Merged

Add Memshare service for GPS #158

merged 15 commits into from Mar 12, 2021

Conversation

TravMurav
Copy link
Member

@TravMurav TravMurav commented Jan 17, 2021

I still need to:

  • Decide if memshare actually needs it's own dir
  • maybe reword message definition comments a bit so they look better
  • maybe rename macro consts
  • break lines so they are less than 80/100
  • enable it in defconfig
  • check if it works as module
  • drop debug messages OR make them dev_dbg
  • Reword Kconfig
  • fix Dt commit
  • add dt binding docs and headers, replace DHMS_MEM_PROC_MPSS_V01 comment

Tested devices:

  • crackling (by travmurav)
  • a3lte (by travmurav)
  • a5lte (by grimler)
  • serranovelte (@Minecrell)
  • z00l (?)
  • z010d (?)
  • m216
  • l8910
  • harpia
  • osprey
  • wt865x8
  • wt88047 (@Minecrell)

https://gist.github.com/TravMurav/db8c8eb2e8bccf5ed46beefb0b5738d4

arch/arm64/boot/dts/qcom/msm8916.dtsi Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916.dtsi Outdated Show resolved Hide resolved
drivers/soc/qcom/Makefile Outdated Show resolved Hide resolved
@TravMurav TravMurav force-pushed the memshare branch 6 times, most recently from 36c100c to 1b0c3b3 Compare February 3, 2021 17:26
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare_qmi_msg.c Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
@TravMurav TravMurav force-pushed the memshare branch 2 times, most recently from 7d1be67 to 2ee14a4 Compare February 4, 2021 11:17
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
drivers/soc/qcom/memshare.c Show resolved Hide resolved
drivers/soc/qcom/memshare.c Outdated Show resolved Hide resolved
@TravMurav
Copy link
Member Author

@antony-jr I don't think SIM will change much, GPS should work (mostly) regardless of the modem state. There may be something custom in the device that is required for GPS to work though

@TravMurav TravMurav force-pushed the memshare branch 2 times, most recently from d614e7d to cdd600c Compare March 6, 2021 16:36
@stephan-gh
Copy link
Member

@antony-jr

Should I test the GPS with the SIM inserted because up until now I've been testing without SIM?

If you are interested in debugging this further I could give a few more suggestions of things to try on Matrix/IRC (bit annoying to list them all here). But there is also the possibility that it's something very ASUS-special or something that will be fairly hard to figure out.

@antony-jr
Copy link

antony-jr commented Mar 6, 2021

@antony-jr

Should I test the GPS with the SIM inserted because up until now I've been testing without SIM?

If you are interested in debugging this further I could give a few more suggestions of things to try on Matrix/IRC (bit annoying to list them all here). But there is also the possibility that it's something very ASUS-special or something that will be fairly hard to figure out.

Thanks. I will ping you after doing my tests further with SIM and data outside.

@TravMurav TravMurav force-pushed the memshare branch 3 times, most recently from 51a7b19 to ef656a7 Compare March 8, 2021 10:06
drivers/soc/qcom/Kconfig Outdated Show resolved Hide resolved
TravMurav and others added 15 commits March 12, 2021 10:22
CONFIG_QCOM_MEMSHARE_QMI_SERVICE=m

Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
This QMI service provides memory region for remote processors (like
modem) on request. It is known to be used in GPS service in modem
firmware for some (most) of msm8916 devices.

This commit implements "guaranteed allocation" of memory using
reserved-memory regions because gps service crashes on some devices
unless specific address was provided.

Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
This service is used by GPS service in many msm8916 devices.

Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
…Modem+QDSP6 (v5)

Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
…dem+QDSP6 (v6)

Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
… modem

Disable memshare for wt88047, doesn't seem to be needed for GPS to work.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
…or Modem+QDSP6 (v4)

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
…Modem+QDSP6 (v2)

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
…Modem+QDSP6 (v5)

Signed-off-by: Ruby Iris Juric <ruby@srxl.me>
Signed-off-by: Martijn Braam <martijn@brixit.nl>
…QDSP6

Signed-off-by: J.R. Divya Antony <d.antony.jr@gmail.com>
Signed-off-by: Anton Bambura <jenneron@protonmail.com>
Signed-off-by: Devajith V S <devajithvs@gmail.com>
Signed-off-by: Cristian Cozzolino <cristian_ci@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants