Clean ups and fixes for mido, ysl, tissot #125
Conversation
| &pm8953_l10 { | ||
| regulator-min-microvolt = <2800000>; | ||
| regulator-max-microvolt = <3000000>; | ||
| }; |
There was a problem hiding this comment.
Can you add a comment to both l6 and l10 why they're different here or something. Especially the always-on should have a reason
There was a problem hiding this comment.
I don't really know a good comment for this, i just saw downstream uses different voltage values for l10 and there is no always-on definitions in the common.
I have checked other devices and tissot regulators also differs from the common in downstream.
There was a problem hiding this comment.
No schematics available? Maybe git history downstream might help? Assuming Xiaomi doesn't just publish an archive without git history.
There was a problem hiding this comment.
I have checked L10 related to sensors and default value should be 2.800 v but i don't find any info about max why should be 3v. L6 also used by the sensors.
MiCode/Xiaomi_Kernel_OpenSource@09f6450#diff-1d92316904c11eef1f77aa098cc2b3c418bf8ff1e1fcb7f9fef834f3b8ef0b2eL219-R228
There was a problem hiding this comment.
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/09f6450330b57b8df8b4472917c2d71adc0386d4/arch/arm/boot/dts/qcom/msm8953-mtp.dtsi#L149C1-L151C3 it is setting back the max voltage to 2.85v
:(
ysl-o-oss and ysl-p-oss branch is different in the max-voltage android-p using 2.85v
There was a problem hiding this comment.
I have build and decompiled the downstream devicetrees
Android P:
regulator-l10 {
compatible = "qcom,rpm-smd-regulator";
regulator-name = "pm8953_l10";
qcom,set = <0x03>;
status = "okay";
regulator-min-microvolt = <0x2ab980>;
regulator-max-microvolt = <0x2b7cd0>;
qcom,init-voltage = <0x2ab980>;
regulator-always-on;
linux,phandle = <0xd5>;
phandle = <0xd5>;
};
Android O:
regulator-l10 {
compatible = "qcom,rpm-smd-regulator";
regulator-name = "pm8953_l10";
qcom,set = <0x03>;
status = "okay";
regulator-min-microvolt = <0x2ab980>;
regulator-max-microvolt = <0x2b7cd0>;
qcom,init-voltage = <0x2ab980>;
linux,phandle = <0xd5>;
phandle = <0xd5>;
};
It should be between 2.8-2.85 but fdt dumped from recovery uses 2.8-2.8
wcnss and wcnss_iris node is removed because they are defined in the msm8953-xiaomi-common. Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
barni2000
force-pushed
the
dts_fixes
branch
2 times, most recently
from
51f2445
to
4009108
Compare
barni2000
changed the title
- fixed regulators - add alias for sdhc_1 and sdhc_2 - remove invalid ramoops node - remove led definition Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
Duplicated panel node has been removed. wcnss_iris compatible has been set to qcom,wcn3680. Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
Ysl:
MiCode/Xiaomi_Kernel_OpenSource@09f6450#diff-1d92316904c11eef1f77aa098cc2b3c418bf8ff1e1fcb7f9fef834f3b8ef0b2eL219-R228
Mido:
Tissot: