Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misspellings in comments and output of msm #246

Merged
merged 2 commits into from
Mar 13, 2014
Merged

Correct misspellings in comments and output of msm #246

merged 2 commits into from
Mar 13, 2014

Conversation

kbmorris
Copy link
Contributor

@kbmorris kbmorris commented Mar 5, 2014

Hi,
I would like to make some improvements to the project but am unfamiliar with Git. To familiarize myself, I made the trivial changes to msm that correct typos in order to validate my Git workflow.

@zachlatta
Copy link
Contributor

Nice catches!

Few comments:

  • The Merriam-Webster dictionary has entries for both uppercase and lowercase. I'd consider both correct instead of upper-case and lower-case, respectively.
  • Timestamp is also correct and doesn't need to be time-stamp.
  • World storage should be two separate words.

@kbmorris
Copy link
Contributor Author

kbmorris commented Mar 6, 2014

Hi. So I hope you do not mind taking a little time to spell out the process from here. First, is this the best way to offer commits; from a fork of the project?

Also, it appears the commit is under discussion and not yet merged. I think you may want me to go back with your comments and make further adjustments to the file. Is this correct?

Assuming that I would reasonably revert the spelling of upper-case, lower-case and time-stamp.
In the case of World storage, could I point out that World storage was found to be represented both ways in the file; but as it appeared it was intended to convey the directory name 'worldstorage' I though the space should be omitted but I may have not interpreted context correctly.

Reverted upper-case to uppercase; lower-case to lowercase;
and time-stamp to timestamp.
zachlatta added a commit that referenced this pull request Mar 13, 2014
Correct misspellings in comments and output of msm
@zachlatta zachlatta merged commit 6f9968d into msmhq:master Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants