Convert server txt files to json #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default server files from txt to json. The only exception is ops.txt which is still populated with users from DEFAULT_OPS_LIST on server creation. Until msm is updated to correctly populate ops.json on startup, msm relies on minecraft server's mechanism to convert ops.txt. Fixes issue #404
This commit updates the wl, bl, and op commands to no longer edit their corresponding server files. msm still edits config settings in files, but relies on minecraft server to manage it's own files, passing the commands to the running server for changes. Minecraft server moved to json in version 1.7.2 which made directly editing txt files no longer work. This change follows the pattern of the other passthrough commands that if the server isn't running, returns error_exit informing the user the server is not running. Fixes issue #404
|
I merged this, as it looks reasonable. I'm not sure what's the procedure to release new versions anymore, as I don't have admin rights, and I think the CI integration has been broken for some time. |
|
You have to create a new tag then create a new release for that tag. Marcus has a gitbump script that makes incrementing the tag easy, but you could also increment the tag number by hand. You also have to update the change log with all of the changes since the last version. |
|
Well, this will need fixing a build too, and I don't have permissions for that. A bit hard to maintain the project when I can't even create a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the default server files from txt to json.
To support that change, additionally update the wl, bl, and op
commands to no longer edit their corresponding server files but
rely on passthrough commands to the minecraft server.
Operationally, the only difference the user will see is when running
the commands when the server is not running. Rather than edit
the txt file, msm will return "Server servername is not running."
Fixes issue #404