You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When passing a value of 0 to the below or above assertions, the assertions checks that the actual distance is greater than or equal to 0, rather than exactly equal. I think this is fine as a default if no distance is provided, but when providing a value, I think it makes more sense to do an exact check.
This is because the logic assumes that if the distance is 0 you don't want an exact check:
When passing a value of
0
to thebelow
orabove
assertions, the assertions checks that the actual distance is greater than or equal to0
, rather than exactly equal. I think this is fine as a default if no distance is provided, but when providing a value, I think it makes more sense to do an exact check.This is because the logic assumes that if the distance is
0
you don't want an exact check:cypress-layout-inspector/src/assertions/position.js
Line 88 in aaeae34
Happy to raise a PR to fix this if you agree that this behaviour is a bug.
Cheers
The text was updated successfully, but these errors were encountered: