This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mihkel,
Thanks for the awesome service. We found that with one of our tools, the contents we wanted in the PDF wasn't always ready when the DOM was loaded, so we added a few options.
I also made some improvements to the dockerfile so that the build layers could be cached and not always rebuilt. When making code changes, only the last few layers get updated vs all the apt-get install command running again.
delay
andwaitForText
delay
should be an integer expressed in seconds, when specified the pdf generation will delay until the time is met.waitForText
should be a string that will eventually appear. The application will continually scan until such time the text is found or theTIMEOUT
is reached. Once the text is found the PDF will get generated. This is useful if text is loaded via XHR or websocket requests after the inital dom is ready.