Add correct version dependency. #23
Conversation
Support for pear was added in the php cookbook version 1.1.0.
|
Sure thing, I'm all for adding more restrictive constraints! but if we're going to do it, isn't it |
|
The earliest release of the PHP cookbook which was tagged in Git was 1.1.0 (see https://github.com/opscode-cookbooks/php/releases). I haven't confirmed how the Chef code checks version numbers, but other cookbooks appear to reference git tag names. |
|
Any version from the community site api is valid, which goes back further than the tags :) |
As pointed out by @patcon, even though no git tags exist for version 0.99.0, it's still a valid release version to depend on.
|
@patcon I've added a commit to fix the dependency as you suggested. |
| @@ -5,7 +5,7 @@ | |||
| description "Installs drush, the Drupal Shell." | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.rdoc')) | |||
| version "0.10.0" | |||
| depends "php" | |||
| depends "php", "~> 0.99.0" | |||
There was a problem hiding this comment.
I think the cautious operator would break things, since it would cap the acceptable version at 0.99.x, right?
|
Oh, wow, I didn't realize that was a caution operator. Still, though, everything seemed to work fine in my runlists... I didn't get any problems. Thanks for your work on this! |
Support for pear was added in the php cookbook version 1.1.0.