Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <algorithm> header to assump_test.cpp #686

Merged
merged 1 commit into from Aug 16, 2022
Merged

Conversation

maximaximal
Copy link
Contributor

Without this header, std::sort is not included directly in this header file, but transitively over the stp/googletest distribution, in the include/gtest/internal/gtest-port.h file, included by include/gtest/internal/gtest-string.h, included by include/gtest/gtest.h.

This change makes it easier to use a different GTest implementation, which is easier for some package management mechanisms.

Without this header, std::sort is not included directly in this header file, but transitively over the stp/googletest distribution, in the `include/gtest/internal/gtest-port.h` file, included by `include/gtest/internal/gtest-string.h`, included by `include/gtest/gtest.h`.

This change makes it easier to use a different GTest implementation, which is easier for some package management mechanisms.
@msoos msoos merged commit 9bf1d82 into msoos:master Aug 16, 2022
@msoos
Copy link
Owner

msoos commented Aug 16, 2022

NICE! Thank you so much!

Mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants