Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code to work with dmd 2.083 #137

Closed
wants to merge 1 commit into from
Closed

Conversation

Marenz
Copy link

@Marenz Marenz commented May 30, 2019

No description provided.

@msoucy
Copy link
Owner

msoucy commented May 31, 2019

Can you demonstrate how this breaks? It seems to work fine for me with dmd 2.086

@Marenz
Copy link
Author

Marenz commented May 31, 2019

Did you use the dev-1.x branch?

@msoucy
Copy link
Owner

msoucy commented May 31, 2019

Yes - there are several deprecations (not surprising, considering that I haven't touched the 1.x branch in years, and wouldn't recommend anyone use it) but running a dub test still passes successfully.

Per 19.16.8.3 of the dlang standard, the code you modify is correct.

Please provide a sample that shows how the current code breaks using the latest compiler, that is fixed by your patch, so I can see what behavior causes problems.

@Marenz
Copy link
Author

Marenz commented May 31, 2019

wouldn't recommend anyone use it

I have to use it because the 2.x version removed a feature that I needed in my projects

Specifcally, I am getting this error:

../../.dub/packages/dproto-1.3.2/dproto/import/dproto/buffers.d(297,7): Error: scope variable val assigned to this with longer lifetime

running a simple dub test in the dproto causes this error. I ran it with dmd 2.083.1

@Marenz
Copy link
Author

Marenz commented May 31, 2019

hmm indeed, the error is gone on the newer dmds..

@msoucy
Copy link
Owner

msoucy commented May 31, 2019

I can't find which version fixed it, but it is indeed fixed in 2.086.0

@msoucy msoucy closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants