Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings of unreachable code + tabs -> spaces #3

Merged
merged 7 commits into from
Jan 20, 2016
Merged

Fix warnings of unreachable code + tabs -> spaces #3

merged 7 commits into from
Jan 20, 2016

Conversation

Zalastax
Copy link
Contributor

@msoucy
Copy link
Owner

msoucy commented Jan 19, 2016

Can you add a unit test to help improve our coverage?

@Zalastax
Copy link
Contributor Author

Lots of unit tests added!
Coveralls is having unrelated problems though.

@msoucy
Copy link
Owner

msoucy commented Jan 20, 2016

LGTM :shipit:

msoucy added a commit that referenced this pull request Jan 20, 2016
@msoucy
Merge pull request #3 from Zalastax/master
a34a92c 
Fix warnings of unreachable code + tabs -> spaces
@msoucy msoucy merged commit a34a92c into msoucy:master Jan 20, 2016
@Zalastax
Copy link
Contributor Author

Thanks! 🙇 Please create a new release so I can update painlessjson

@msoucy
Copy link
Owner

msoucy commented Jan 21, 2016

v0.1.0 tagged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zalastax @msoucy