This repository has been archived by the owner on Aug 7, 2018. It is now read-only.
[WIP] Improve responsive resize handling #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure `_handleResize` callback is always defined, even if `responsive` prop is false initially. The callback might be needed if we want to add an event listener later on in `componentWillReceiveProps`. * Use new `refresh` method from katspaugh/wavesurfer.js#1146 to redraw the wavefrom and also update the play progress without actually seeking in the media file. There does not appear to be a need to pause while doing this. Wait for `isReady`, though, to prevent calling refresh before `wavesurfer#init` has been called in `componentDidMount`.
|
Looks like responsiveness has been removed on the v2 branch and will be handled by wavesurfer itself in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
_handleResizecallback is always defined, even ifresponsiveprop is false initially. The callback might be needed if we want to add an event listener later on incomponentWillReceiveProps.Use new
refreshmethod to redraw the wavefrom and also update the play progress without actually seeking in the media file. There does not appear to be a need topause while doing this. Wait for
isReady, though, to prevent calling refresh beforewavesurfer#inithas been called incomponentDidMount.Once katspaugh/wavesurfer.js#1146 is merged and released, the peer dependency needs to be updated accordingly.