Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endtime handling #484

Open
pavlis opened this issue Jan 17, 2024 · 1 comment
Open

endtime handling #484

pavlis opened this issue Jan 17, 2024 · 1 comment

Comments

@pavlis
Copy link
Collaborator

pavlis commented Jan 17, 2024

I don't know if we had this issue before or if I created it with the new Database implementation that was just merged to master. What I'm finding is that save_data is not saving an important metadata attribute with the key "endtime". That absolutely needs to be stored in wf documents as a very very common search is to select waveforms in a time interval. If endtime is not defined that becomes really awkward.

@wangyinz confirm you agree that saving endtime should be always done and I'll fix it.

@pavlis
Copy link
Collaborator Author

pavlis commented Jan 17, 2024

I looked at the code and realized this was an easy patch to fix. I just did it here on github and issued a pull request.

Note the problem was even worse than stated above. If a datum was windowed and then saved the start time would also be wrong because it wasn't being replaced in the document constucted form the datum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant