Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update window.py #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update window.py #387

wants to merge 1 commit into from

Commits on Jan 30, 2023

  1. Update window.py 

    I ran across this code when I was trying to remember now to use the mspass_func_wrapper and noticed:
1. I does not have docstring
2. It is not correct as previous version of this had a bug in how it set the start of time window.   You can see the one line change I made.  It may break the tests.

I actually think this function is not needed.   To my mind it would be harder to remember a function with a similar but different name than to just remember what a TimeWindow object is or use a start and end time explicitly set as two parameters.
    @pavlis
    pavlis committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f0eef39 View commit details
    Browse the repository at this point in the history