-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new dockerfile #403
added new dockerfile #403
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 53.75% 53.75%
=======================================
Files 131 131
Lines 20781 20781
=======================================
+ Hits 11170 11171 +1
+ Misses 9611 9610 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It works fine in my local docker. I built a docker image from this branch and use |
|
…into new_dockerfile
It is solved by changing |
The former build failure on arm is due to the use of cmake arguments SSE2 and AVX2 when building numcodecs. ARM has no support for SSE2 and AVX2. I disabled them and updated the Python version to 3.8, all tags of images can be built successfully now. When running the images, all of them built in amd64 work well. In arm64, images built by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good work! This is pretty good except that I have a few questions which are in the inline comments. I think the questions implies to all these containers instead of just the ones with the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! I only have some questions posted in the comment. I think we could merge it pretty soon!
btw, we should address the issue (#408 (comment)) in this PR. The variables needs to be removed from the startup script and put into the container. @Yangzhengtang Could you please help @Aristoeu fix it? Thank you! |
pandas has a new version 2.0.0 on April 3, and has removed deprecated removed path and pythonpath from the startup script and put into the container |
I just tried building the containers locally with arm64, and they all failed. One obvious issue that I can see is that that in the Dockerfile, there are multiple reference to I also realized that the Also, the |
Thanks for testing! I updated mongo to 6.0 to be compatible with ubuntu 22, and applied the changes. I built Dockerfile locally in amd and arm successfully. They should all work now. Besides, the |
Thank you! I will merge it now. |
Based on SeisSCOPED container, updated mongo to 5.0, Python to 3.8