Applying Traefik image pull from ACR by using imperative instructions in step 08 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckittel
requested changes
Aug 20, 2021
There was a problem hiding this comment.
This all looks good to me! 👍
However, I think this is the LAST usage of docker.io now right? If so, shouldn't we have an Azure Policy change to go with this PR? https://github.com/mspnp/aks-baseline-multi-region/blob/main/cluster-stamp.json#L1718 (while you're in there, you can fix the unescaped .s as well, that would be good)
|
Also, we should be able to remove an Azure Firewall Allow rule now for docker.io. That was listed in the task as being inscope for this work. |
ckittel
requested changes
Aug 20, 2021
|
Thanks @ckittel !! I'm gonna test the hell out it before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.