Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aks 1.22 upg #37

Merged
merged 13 commits into from
Oct 26, 2021
Merged

Aks 1.22 upg #37

merged 13 commits into from
Oct 26, 2021

Conversation

magrande
Copy link
Contributor

@magrande magrande commented Oct 19, 2021

@ckittel still, WIP, but you can start reviewing it while I test.

@magrande magrande requested a review from ckittel October 19, 2021 21:45
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question/observation.

@magrande magrande marked this pull request as ready for review October 25, 2021 15:39
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Here are just a couple observations on quick glance.

…ing lines in AAD pod identity deployment file
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One open question: "Did you confirm that the AAD Pod Identity exceptions were landing in the correct namespaces?"

@magrande magrande merged commit 23c68ba into main Oct 26, 2021
@ckittel ckittel deleted the aks-1.22-upg branch September 12, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants